Repository navigation
Conversation
dkachuma
marked this pull request as ready for review
October 19, 2026 15:49
dkachuma
requested review from
OmarDuran,
bd713,
herve-gross,
jhuang2601,
joshua-white,
rrsettgast and
tjb-ltk
as code owners
October 19, 2026 15:49
herve-gross
approved these changes
Oct 19, 2026
herve-gross
left a comment
Contributor
There was a problem hiding this comment.
Thanks! This is a great example, very useful.
jhuang2601
requested changes
Oct 30, 2026
| - Mesh file and well trajectories | ||
| * - ``dome_properties.xml`` | ||
| - Porosity and permeability of every rock type | ||
| * - ``dome_soreide_whitson_bench.xml``, ``dome_kvalue_bench.xml`` |
Contributor
There was a problem hiding this comment.
I tried to rerun this benchmark example, but these two xml files are missing.
Can you add them to the PR?
Contributor
Author
There was a problem hiding this comment.
They should be in inputFiles/compositionalMultiphaseWell. Did I mistype the location of the files?
I would recommend running the bench cases with at least 4 mpi ranks.
| (20.0, "end of simulation"), | ||
| ] | ||
|
|
||
| ROCK_COLORS = ["#00aaff", "#ff0000", "#00ff00"] # SAND, CLAY, CAPROCK |
Contributor
Contributor
Author
There was a problem hiding this comment.
Thanks for catching this. I have swapped the colours.
jhuang2601
approved these changes
Nov 3, 2026
jhuang2601
left a comment
Contributor
There was a problem hiding this comment.
By relaxing flashTolerance to 1.0e-3, the case now runs to completion using fix/bd713/pvt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds an example for CO2 Injection into a Depleted Reservoir