Skip to content

Add depleted reservoir example - #4141

Open
dkachuma wants to merge 23 commits into
developfrom
dkachuma/depletion-example
Open

dkachuma wants to merge 23 commits into
developfrom
dkachuma/depletion-example

Conversation

@dkachuma

@dkachuma dkachuma commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

@dkachuma dkachuma self-assigned this Sep 9, 2026
@dkachuma dkachuma added flag: ready for review ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline ci: run code coverage enables running of the code coverage CI jobs type: docs ci: run device builds Allows to run the device (CUDA/HIP) builds labels Oct 19, 2026
@dkachuma
dkachuma marked this pull request as ready for review October 19, 2026 15:49

@herve-gross herve-gross left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a great example, very useful.

- Mesh file and well trajectories
* - ``dome_properties.xml``
- Porosity and permeability of every rock type
* - ``dome_soreide_whitson_bench.xml``, ``dome_kvalue_bench.xml``

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to rerun this benchmark example, but these two xml files are missing.
Can you add them to the PR?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They should be in inputFiles/compositionalMultiphaseWell. Did I mistype the location of the files?

I would recommend running the bench cases with at least 4 mpi ranks.

(20.0, "end of simulation"),
]

ROCK_COLORS = ["#00aaff", "#ff0000", "#00ff00"] # SAND, CLAY, CAPROCK

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the output figure, it seems that the regions in the rock-type plot are labeled incorrectly.
The colors and legend entries for SAND and CAPROCK appear to be swapped.

Image

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. I have swapped the colours.

@jhuang2601 jhuang2601 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By relaxing flashTolerance to 1.0e-3, the case now runs to completion using fix/bd713/pvt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run device builds Allows to run the device (CUDA/HIP) builds ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: ready for review type: docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants